Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): Allow secrets in headers #14743

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

LarsStegman
Copy link
Contributor

@LarsStegman LarsStegman commented Feb 9, 2024

Summary

Now secrets can be used in HTTP header values.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14701

@LarsStegman LarsStegman marked this pull request as ready for review February 9, 2024 13:20
Otherwise the secrets never become linked.
@LarsStegman LarsStegman changed the title Set http headers to be secrets in the config feat: inputs.http/outputs.http headers to be secrets in the config Feb 9, 2024
@LarsStegman
Copy link
Contributor Author

@powersj Will this be released in a patch release or the minor release (in March?)

@LarsStegman LarsStegman changed the title feat: inputs.http/outputs.http headers to be secrets in the config feat: inputs.http/outputs.http HTTP header values secrets Feb 9, 2024
@powersj
Copy link
Contributor

powersj commented Feb 12, 2024

@powersj Will this be released in a patch release or the minor release (in March?)

Looking through the change log it looks like we align secret store support as a new feature, so that means the next minor release in March.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this! Two small comments.

plugins/inputs/http/http.go Show resolved Hide resolved
plugins/outputs/http/http.go Show resolved Hide resolved
@powersj powersj self-assigned this Feb 12, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 12, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Feb 12, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @LarsStegman! I would just shorten the comment on the secrets... What do you think?

plugins/inputs/http/README.md Outdated Show resolved Hide resolved
plugins/outputs/http/README.md Outdated Show resolved Hide resolved
@srebhan srebhan changed the title feat: inputs.http/outputs.http HTTP header values secrets feat(http): Allow secrets in headers Feb 12, 2024
@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins plugin/secretstores labels Feb 12, 2024
@LarsStegman
Copy link
Contributor Author

LarsStegman commented Feb 12, 2024

@srebhan I thought it would be clearer, but whatever you prefer.

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LarsStegman!

@srebhan srebhan merged commit 4f0ac6e into influxdata:master Feb 12, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 12, 2024
@LarsStegman LarsStegman deleted the feat/http-header-secrets branch May 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(outputs.http): Support secret store for Authorization header
4 participants