Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(processors.execd): Accept tracking metrics instead of dropping them #14770

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 12, 2024

Summary

Currently, this plugin drops incoming metrics as we cannot decide if a metric passes the processor or not. However, it is very likely that the metric passes the processor. In any case, the processor does something with the metric and thus we should accept it.

The PR also adds a unit-test for tracking metrics.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14715

@telegraf-tiger telegraf-tiger bot added area/execd Issues related to execd or plugins that would be better suited to be used through execd fix pr to fix corresponding bug plugin/processor labels Feb 12, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.62 % for linux amd64 (new size: 228.5 MB, nightly size 224.8 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit 616ad30 into influxdata:master Feb 12, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.29.5 milestone Feb 12, 2024
powersj pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/execd Issues related to execd or plugins that would be better suited to be used through execd fix pr to fix corresponding bug plugin/processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

processors.execd: Add unit-tests for tracking metrics
2 participants