Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.websocket): Allow specifying secrets in headers #14836

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

LarsStegman
Copy link
Contributor

Summary

Make the header values secrets instead of plain strings to support setting bearer tokens properly.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14835

@LarsStegman LarsStegman marked this pull request as ready for review February 16, 2024 13:41
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 16, 2024
@LarsStegman LarsStegman changed the title feat(websocket): Allow secrets in headers feat(websocket): allow secrets in headers Feb 16, 2024
@LarsStegman LarsStegman force-pushed the feat/websocket-secrets branch from f34843e to e1cf58f Compare February 16, 2024 13:44
@srebhan srebhan changed the title feat(websocket): allow secrets in headers feat(outputs.websocket): Allow specifying secrets in headers Feb 16, 2024
@telegraf-tiger telegraf-tiger bot added the plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins label Feb 16, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LarsStegman thanks for the PR! Just two mostly cosmetic comments...

plugins/outputs/websocket/websocket.go Outdated Show resolved Hide resolved
plugins/outputs/websocket/websocket.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Feb 16, 2024
LarsStegman and others added 2 commits February 16, 2024 21:15
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -1.66 % for linux amd64 (new size: 224.8 MB, nightly size 228.6 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LarsStegman!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 19, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Feb 19, 2024
@powersj powersj merged commit da56ebd into influxdata:master Feb 20, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 20, 2024
@LarsStegman LarsStegman deleted the feat/websocket-secrets branch May 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(outputs.websocket): support secrets in headers
4 participants