-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(inputs.syslog): Use common/socket implementation #14837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
area/syslog
chore
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
labels
Feb 16, 2024
srebhan
force-pushed
the
syslog_cleanup
branch
from
February 19, 2024 13:39
cd69e8e
to
faca00b
Compare
srebhan
force-pushed
the
syslog_cleanup
branch
from
February 19, 2024 16:17
faca00b
to
a8e5693
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added
the
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
label
Feb 20, 2024
powersj
approved these changes
Feb 23, 2024
DStrand1
approved these changes
Feb 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/syslog
chore
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up the code in
inputs.syslog
, adds multiple unit-tests and switch to thecommon/socket
implementation, removing duplicate code.If requested, I can also split the PR into the
common/socket
part and the syslog part...Based on PR #14828
Checklist
Related issues
resolves #10121