Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(inputs.syslog): Use common/socket implementation #14837

Merged
merged 20 commits into from
Feb 23, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 16, 2024

Summary

This PR cleans up the code in inputs.syslog, adds multiple unit-tests and switch to the common/socket implementation, removing duplicate code.

If requested, I can also split the PR into the common/socket part and the syslog part...

Based on PR #14828

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #10121

@telegraf-tiger telegraf-tiger bot added area/syslog chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 16, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 20, 2024
@powersj powersj removed their assignment Feb 23, 2024
@DStrand1 DStrand1 merged commit 0e6b4f0 into influxdata:master Feb 23, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/syslog chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syslog plugin disconnects TCP connection when idle, contrary to documentation
3 participants