Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serializers.csv): Allow specifying fixed column order #14870

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 21, 2024

Summary

Currently, the CSV serializer outputs the metric data in a fixed format timestamp, name, tags..., fields... with tags and fields being sorted alphabetically. However, some applications do expect a fixed column order. This PR adds a configuration option to specify the order of columns.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14841

@telegraf-tiger telegraf-tiger bot added area/csv csv parser/serialiser related feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/serializer labels Feb 21, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 22, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this.

@powersj powersj removed their assignment Feb 22, 2024
@DStrand1 DStrand1 merged commit 2942f84 into influxdata:master Feb 22, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csv csv parser/serialiser related feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/serializer ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV serializer should allow to configure the order of the generated columns
3 participants