Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.amd_rocm_smi): Add startup_error_behavior config option #14872

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

smokhov
Copy link
Contributor

@smokhov smokhov commented Feb 21, 2024

Summary

Similarly to NVIDIA in #14680 completes the 2nd part of the #14603 issue for AMDGPU.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14603

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 21, 2024
@telegraf-tiger
Copy link
Contributor

@smokhov smokhov marked this pull request as ready for review February 21, 2024 19:17
@smokhov
Copy link
Contributor Author

smokhov commented Feb 21, 2024

@powersj @srebhan -- over to you. Thank you!

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smokhov!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 22, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj merged commit c4069a4 into influxdata:master Feb 22, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow Telegraf to start even if nvidia-smi or rocm-smi inputs are not available on a cluster
4 participants