-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.dns_query): Fill out additional record fields #14979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@powersj I do have one suggestion and wonder if it makes sense to also add the additional fields of all other supported type (see parseRecordType()
)!?
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
For the majority of the other types there is nothing else or there is a |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
@srebhan we don't do reverse looksups (e.g. ip -> dns name) so I believe this is ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @powersj!
(cherry picked from commit 70e2ab6)
Summary
Checklist
Related issues
resolves #14956