Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.dns_query): Fill out additional record fields #14979

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 12, 2024

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14956

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 12, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 12, 2024
@powersj powersj marked this pull request as ready for review March 12, 2024 18:41
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powersj I do have one suggestion and wonder if it makes sense to also add the additional fields of all other supported type (see parseRecordType())!?

plugins/inputs/dns_query/dns_query.go Outdated Show resolved Hide resolved
powersj and others added 2 commits March 14, 2024 07:54
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@powersj
Copy link
Contributor Author

powersj commented Mar 14, 2024

@powersj I do have one suggestion and wonder if it makes sense to also add the additional fields of all other supported type (see parseRecordType())!?

For the majority of the other types there is nothing else or there is a cdomain-name, which I have assumed was the domain we are looking up and captured as a tag already. Is that your assessment as well?

@telegraf-tiger
Copy link
Contributor

@powersj
Copy link
Contributor Author

powersj commented Mar 14, 2024

@srebhan we don't do reverse looksups (e.g. ip -> dns name) so I believe this is ready to go.

@powersj powersj requested a review from srebhan March 14, 2024 17:58
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan removed their assignment Mar 14, 2024
@DStrand1 DStrand1 merged commit 70e2ab6 into influxdata:master Mar 14, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.1 milestone Mar 14, 2024
powersj added a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegraf inputs.dns_query plugin does not return any data for SOA type RRs
3 participants