-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.diskio): Add missing udev properties #15003
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, one question about the readme.
Sorry to chime in a little late, but unless I am mistaken, the default value for |
While booleans default to false, when we initialize the plugin it defaults to true: https://github.com/influxdata/telegraf/blob/master/plugins/inputs/diskio/diskio.go#L192 Let me know if you are seeing otherwise. |
I didn't see the init bloc while searching in the code. |
(cherry picked from commit c9fb4e7)
Summary
Add the missing
DEVPATH
,DEVNAME
andDEVTYPE
properties. In the course also fix the sample.conf to represent the default values.Checklist
Related issues
resolves #3663