-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.phpfpm): Add timeout for fcgi #15036
Conversation
6cb1744
to
668fb06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PierreF thanks for fixing this issue! Could you please add a unit-test for the timeout?!?
Use the timeout of php-fpm with fgci protocol Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
668fb06
to
449e44c
Compare
I've added the test in the same commit (I'm unsure if you prefer a single commit with code & test or if you prefer avoid push force). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments regarding the unit-test...
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @PierreF!
(cherry picked from commit 4c1aa59)
Summary
The input PHP-FPM don't have timeout when talking (F)CGI protocol, which could lead to input blocked forever.
The timeout exists and was used for HTTP, but not for fcgi.
Checklist
Related issues
resolves #15035