Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agent): Ensure import of required package for pprof support #15054

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix(agent): Ensure import of required package for pprof support #15054

merged 2 commits into from
Apr 2, 2024

Conversation

rebrendov
Copy link
Contributor

@rebrendov rebrendov commented Mar 23, 2024 •
edited
Loading

Summary

Pretty sure net/http/pprof got accidentally lost in this commit bd516ae
This MR adds it back in

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15053

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@rebrendov
Copy link
Contributor Author

!signed-cla

@rebrendov rebrendov changed the title Add import of net/http/pprof back in fix(agent): add import of net/http/pprof back in Mar 23, 2024
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 23, 2024
@powersj powersj added the waiting for response waiting for response from contributor label Mar 25, 2024
@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Mar 28, 2024
@rebrendov
Copy link
Contributor Author

Works on master, my issue was that I was using a custom build.

@rebrendov rebrendov closed this Mar 28, 2024
@powersj powersj reopened this Mar 28, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 1, 2024
@srebhan srebhan changed the title fix(agent): add import of net/http/pprof back in fix(agent): Make sure we import the required package for pprof support Apr 2, 2024
@srebhan srebhan changed the title fix(agent): Make sure we import the required package for pprof support fix(agent): Ensure import of required package for pprof support Apr 2, 2024
@srebhan srebhan merged commit 6cd4821 into influxdata:master Apr 2, 2024
28 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Apr 2, 2024
powersj pushed a commit that referenced this pull request Apr 22, 2024
@rebrendov @powersj
fix(agent): Ensure import of required package for pprof support (#15054)
0e3e9cb 
Co-authored-by: Josh Powers <powersj@fastmail.com>
(cherry picked from commit 6cd4821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

@DStrand1 DStrand1

Labels
area/agent fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

pprof does not work for custom builds?
4 participants
@rebrendov @powersj @srebhan @DStrand1