Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.win_eventlog): Handle empty query correctly #15132

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(inputs.win_eventlog): Handle empty query correctly #15132

merged 1 commit into from
Apr 10, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Apr 9, 2024

Summary

And empty query should return all results, so this PR set a suitable default, i.e. *.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15115

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 9, 2024
@srebhan srebhan mentioned this pull request Apr 9, 2024
Closed
@srebhan srebhan added the area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) label Apr 9, 2024
@srebhan srebhan self-assigned this Apr 9, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Apr 9, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 10, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Apr 10, 2024
@powersj powersj merged commit 8e50594 into influxdata:master Apr 10, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.2 milestone Apr 10, 2024
powersj pushed a commit that referenced this pull request Apr 22, 2024
@srebhan @powersj
fix(inputs.win_eventlog): Handle empty query correctly (#15132)
2ec9236 
(cherry picked from commit 8e50594)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

@DStrand1 DStrand1

Labels
area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.30.2
Development

Successfully merging this pull request may close these issues.

[inputs.win_eventlog] not starting when using only eventlog_name
3 participants
@srebhan @powersj @DStrand1