fix(inputs.modbus): Avoid overflow when calculating with uint16 addresses #15146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using addresses at the end of the address range, the batch-limitation calculation might overflow the
uint16
range. This PR checks the range now before doing the computation to make sure we do not overflow.Furthermore, users might provide invalid configuration by using an address at the end of the address-range with a too-large data-type in
metric
andrequest
configuration-styles. This PR also checks this overflow.Note: The
register
style is safe as there you explicitly need to specify the addresses.Checklist
Related issues
resolves #15138