-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.sqlserver): Honor timezone on backup metrics #15154
Conversation
Thanks so much for the pull request! |
!signed-cla |
@Trovalo - this sounds like the right thing to do, but could you double check as well? Thanks! |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. but waiting for @Trovalo to have his say...
(cherry picked from commit 26b7db8)
We have been testing the sql server input in monitoring our production server and for the last_full_backup/last_differential_backup/last_log_backup we can see that if the timezone is different than UTC on the server, the time is not displayed properly. By adding the timezone offset in the query, we have removed the issue.
Summary
If it provided in the issue.
Checklist
Related issues
Timezone Not Inlcuded in Backup in SQL Server input #15153
resolves #