Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.sqlserver): Honor timezone on backup metrics #15154

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Grosoiu
Copy link
Contributor

@Grosoiu Grosoiu commented Apr 15, 2024

We have been testing the sql server input in monitoring our production server and for the last_full_backup/last_differential_backup/last_log_backup we can see that if the timezone is different than UTC on the server, the time is not displayed properly. By adding the timezone offset in the query, we have removed the issue.

Summary

If it provided in the issue.

Checklist

  • [X ] No AI generated code was used in this PR

Related issues

Timezone Not Inlcuded in Backup in SQL Server input #15153

resolves #
2
Untitled
poza1

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@Grosoiu
Copy link
Contributor Author

Grosoiu commented Apr 15, 2024

!signed-cla

@Grosoiu Grosoiu changed the title Fixed Timezone Delay on Backup metric fix(timezone): correct delay on backup metric Apr 15, 2024
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Apr 15, 2024
@Grosoiu Grosoiu changed the title fix(timezone): correct delay on backup metric fix(inputs.sqlserver): correct delay for timezone on backup metrics Apr 15, 2024
@telegraf-tiger telegraf-tiger bot added area/sqlserver plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 15, 2024
@powersj
Copy link
Contributor

powersj commented Apr 15, 2024

@Trovalo - this sounds like the right thing to do, but could you double check as well? Thanks!

@powersj powersj requested a review from Trovalo April 15, 2024 13:24
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. but waiting for @Trovalo to have his say...

@srebhan srebhan changed the title fix(inputs.sqlserver): correct delay for timezone on backup metrics fix(inputs.sqlserver): Honor timezone on backup metrics Apr 22, 2024
@powersj powersj merged commit 26b7db8 into influxdata:master Apr 22, 2024
28 checks passed
@github-actions github-actions bot added this to the v1.30.2 milestone Apr 22, 2024
powersj pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants