Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.diskio): Update path to in /sys #15155

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 15, 2024

Summary

Update default path from /sys/block to /sys/class/block. This change was made to the kernel 16 years ago and is the default location: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=edfaa7c36574f1bf09c65ad602412db9da5f96bf

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15151

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 15, 2024
@powersj powersj changed the title fix(diskio): Update path to in /sys fix(inputs.diskio): Update path to in /sys Apr 15, 2024
@telegraf-tiger telegraf-tiger bot added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Apr 15, 2024
@sheyabernstein
Copy link

Thank you @powersj

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could add a fallback to the old path, but given that this change was made 16y ago I think we should skip that until issues arise...

@srebhan srebhan removed their assignment Apr 16, 2024
@DStrand1 DStrand1 merged commit 0e5d4d8 into influxdata:master Apr 16, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.30.2 milestone Apr 16, 2024
powersj added a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
4 participants