Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.opensearch): Correctly error during failures or disconnect #15157

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 15, 2024

Summary

The opensearch plugin never tests that we are actually able to connect to the opensearch instance. Instead it goes on tossing bits to a bucket, even if never connected without any errors.

This updates checks in two places 1) during connect that we can actually ping the endpoint and 2) during writes, ensures we had no failures correctly.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15119

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Apr 15, 2024
@powersj powersj self-assigned this Apr 15, 2024
Copy link

@RodrigoDornelles RodrigoDornelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its working!

now reporting erros #15119

@powersj

@powersj
Copy link
Contributor Author

powersj commented Apr 18, 2024

Thanks for confirming!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 18, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Apr 18, 2024
@DStrand1 DStrand1 removed their assignment Apr 18, 2024
@srebhan srebhan merged commit 6e3577f into influxdata:master Apr 19, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.2 milestone Apr 19, 2024
powersj added a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/elasticsearch fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not reporting when failed index in the opensearch
4 participants