Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.procstat): Report consistent I/O on Linux #15186

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Apr 18, 2024

Summary

The fields read_bytes and write_bytes do report the overall I/O including network etc on operating systems such as Windows. However on Linux, those two fields are filled by the I/O to the storage layer which causes inconsistent metrics across operating-systems.

This PR changes the behavior on Linux and is now consistently reporting the overall I/O in read_bytes and write_bytes (using the rchar and wchar information). It furthermore reports the previous (storage-only I/O) via the new disk_read_bytes and disk_write_bytes fields.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #9189

@telegraf-tiger telegraf-tiger bot added area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 18, 2024
@srebhan srebhan self-assigned this Apr 18, 2024
@srebhan srebhan changed the title feat(inputs.procstat): Add fields for cached read/write bytes fix(inputs.procstat): Report consistent I/O on Linux Apr 19, 2024
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Apr 19, 2024
@srebhan srebhan force-pushed the procstat_issue_9189 branch from b23b6dc to 1969374 Compare April 19, 2024 16:01
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 22, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Apr 22, 2024
@powersj powersj removed their assignment Apr 22, 2024
@srebhan srebhan changed the title fix(inputs.procstat): Report consistent I/O on Linux feat(inputs.procstat): Report consistent I/O on Linux Apr 23, 2024
@srebhan srebhan removed the fix pr to fix corresponding bug label Apr 23, 2024
@srebhan srebhan force-pushed the procstat_issue_9189 branch from 1969374 to 4ab2dd8 Compare April 23, 2024 14:02
@srebhan srebhan requested review from powersj and DStrand1 April 23, 2024 14:03
@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Apr 23, 2024
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 46dbab0 into influxdata:master Apr 23, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect procstat IO counters
3 participants