fix(outputs.graphite): Handle local address without port correctly #15224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original PR #14628 which resolved #14614 mishandled the case in which no port is given together with the local address. The integrated code expected
net.SplitHostPort
to return the address even when no port is given, however,net.SplitHostPort
instead returns an emptry string. (https://github.com/golang/go/blob/master/src/net/ipsock.go)Checklist
Related issues
resolves #14614 further