Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.graphite): Handle local address without port correctly #15224

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(outputs.graphite): Handle local address without port correctly #15224

merged 1 commit into from
Apr 25, 2024

Conversation

momoson
Copy link
Contributor

@momoson momoson commented Apr 25, 2024

Summary

The original PR #14628 which resolved #14614 mishandled the case in which no port is given together with the local address. The integrated code expected net.SplitHostPort to return the address even when no port is given, however, net.SplitHostPort instead returns an emptry string. (https://github.com/golang/go/blob/master/src/net/ipsock.go)

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14614 further

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Apr 25, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan changed the title fix(outputs/graphite): Fix usage of local address when no port is given fix(outputs.graphite): Handle local address without port correctly Apr 25, 2024
@telegraf-tiger telegraf-tiger bot added area/graphite plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Apr 25, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @momoson!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 25, 2024
@powersj powersj removed their assignment Apr 25, 2024
@DStrand1 DStrand1 merged commit 42401a3 into influxdata:master Apr 25, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.30.3 milestone Apr 25, 2024
@momoson momoson deleted the fix_local_address_graphite branch April 25, 2024 20:43
powersj pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphite fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow source interface binding for Graphite output
4 participants