Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.influxdb): Add option to define local address #15225

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat(outputs.influxdb): Add option to define local address #15225

merged 1 commit into from
Apr 26, 2024

Conversation

momoson
Copy link
Contributor

@momoson momoson commented Apr 25, 2024

Summary

Add option to set local ip (and port) which allows to select the interface over which the influx server is contacted. Based on #14628.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #4287 (which was closed but never really resolved)

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 25, 2024
@srebhan srebhan changed the title feat(outputs/influxdb[_v2]): Add option to configure local address for influxdb outputs feat(outputs.influxdb*): Add option to define local address Apr 25, 2024
@telegraf-tiger telegraf-tiger bot added the plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins label Apr 25, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @momoson for your contribution. I have two small comments but the overall code looks good. Additionally, I recomment to split the PR into two, one for influxdb and one for v2...

plugins/outputs/influxdb/http.go Outdated Show resolved Hide resolved
plugins/outputs/influxdb_v2/http.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Apr 25, 2024
@momoson momoson changed the title feat(outputs.influxdb*): Add option to define local address feat(outputs.influxdb): Add option to define local address Apr 25, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @momoson!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 25, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Apr 25, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj removed their assignment Apr 26, 2024
@DStrand1 DStrand1 merged commit bf55d78 into influxdata:master Apr 26, 2024
31 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Apr 26, 2024
@momoson momoson deleted the influxdb_local_addr branch April 27, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/influxdb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending data to influxDB through specific interface/bind IP address
4 participants