Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(inputs.prometheus): Remove invalid deprecation statement #15229

Merged
merged 2 commits into from
Apr 25, 2024
Merged

docs(inputs.prometheus): Remove invalid deprecation statement #15229

merged 2 commits into from
Apr 25, 2024

Conversation

ZPascal
Copy link
Contributor

@ZPascal ZPascal commented Apr 25, 2024 •
edited
Loading

Summary

Checklist

  • No AI generated code was used in this PR

Description

  • The change updates the documentation of the Prometheus Input plugin. The response_timeout parameter is generally no longer obsolete and is reused by the HTTP header timeout.

@telegraf-tiger telegraf-tiger bot added the docs Issues related to Telegraf documentation and configuration descriptions label Apr 25, 2024
@ZPascal ZPascal marked this pull request as ready for review April 25, 2024 12:27
@ZPascal
Copy link
Contributor Author

ZPascal commented Apr 25, 2024

@srebhan Could you please check the PR? Thank you

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 25, 2024
@srebhan srebhan changed the title docs: Update the Prometheus input plugin documentation docs(inputs.prometheus): Remove invalid deprecation statement Apr 25, 2024
@telegraf-tiger telegraf-tiger bot added area/prometheus plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 25, 2024
srebhan
srebhan approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZPascal!

@srebhan srebhan merged commit b4cafb4 into influxdata:master Apr 25, 2024
33 checks passed
@github-actions github-actions bot added this to the v1.30.3 milestone Apr 25, 2024
@ZPascal ZPascal deleted the patch-1 branch April 25, 2024 20:50
powersj pushed a commit that referenced this pull request May 20, 2024
@ZPascal @powersj
docs(inputs.prometheus): Remove invalid deprecation statement (#15229)
c3bee59 
(cherry picked from commit b4cafb4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
area/prometheus docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.30.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ZPascal @powersj @srebhan @DStrand1