fix(windows): Make sure to log the final error message #15346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When exiting a program with
log.Fatal
, the program does not execute any deferred calls and will also exit immediately. For logging with the Windows event-logger interface, this means that the connection to the logger is not shut down gracefully and thus the final (and most important) log message is lost.This PR does not use
log.Fatal
to log the message but rather rely onlog.Print
which allows for a graceful exit. Furthermore, we move the logging into therunApp
function which really is the core processing loop.Checklist
Related issues
resolves #14144