Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capability to send metrics through Http API for OpenTSDB #1539

Closed
wants to merge 15 commits into from

Conversation

EricFortin
Copy link
Contributor

@EricFortin EricFortin commented Jul 22, 2016

Modified the opentsdb output plugin so it can also use Http API to send metrics. The Http API has better error management and is easier to debug. Should I squash my changes ? First time contributing.

Required for all PRs:

  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

@@ -29,21 +31,34 @@ var sampleConfig = `
prefix = "my.specific.prefix."

## Telnet Mode ##
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "Telnet Mode"

@sparrc
Copy link
Contributor

sparrc commented Jul 22, 2016

rather than having a use_http option, I would prefer if you integrated it with the name of the host, and then parse out the "scheme" from the url.

ie,

host = "opentsdb.example.com" <-- use tcp
host = "tcp://opentsdb.example.com" <-- use tcp
host = "http://opentsdb.example.com" <-- use http

@EricFortin
Copy link
Contributor Author

I will implement the selection of API based on the host and update the PR. Should I go ahead and update Changelog ?

@sparrc
Copy link
Contributor

sparrc commented Jul 22, 2016

yes, please do, also don't worry about squashing, I can do that within github

@EricFortin
Copy link
Contributor Author

All done I think. Let me know if anythings is missing. Also, do this have a chance of getting in 1.0 ?

@EricFortin
Copy link
Contributor Author

@sparrc Anything else you need from me ?

@EricFortin
Copy link
Contributor Author

@sparrc I had a look at the test failure but I don't see how I my code could affect this. I also checked PR #1543 which had the same problem with totally unrelated code I think. I then ran the test locally and the tail tests passed just fine. What would be the next step ?

@sparrc
Copy link
Contributor

sparrc commented Jul 27, 2016

sorry for the noise, I will kick a rebuild.

I don't think there is anything else, I just need to find time to review again and merge, there is a lot on my plate at the moment so please be patient.

@EricFortin
Copy link
Contributor Author

@sparrc No problem and thanks !

Timestamp int64
Value string
Tags string
type TagSet map[string]string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you make this type? just using a map[string]string is more explicit and readable throughout

@EricFortin
Copy link
Contributor Author

@sparrc I did what you suggested.

@sparrc
Copy link
Contributor

sparrc commented Aug 30, 2016

Thanks @EricFortin, but it looks like your CHANGELOG rebase might have gotten mixed up with other commits. Can you please revert your CHANGELOG change and then rebase, putting your PR into the 1.1 release?

@EricFortin
Copy link
Contributor Author

@sparrc Should be good now. Thanks.

@sparrc sparrc closed this in 6e33a6d Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants