Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Switch to github.com/leodido/go-syslog #15393

Merged
merged 1 commit into from
May 30, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented May 22, 2024

Summary

Migrate to maintained library.

A number of tests were updated to include newlines and/or remove expected errors as the parser seems to be more allowing of input.

Checklist

  • No AI generated code was used in this PR

@powersj powersj self-assigned this May 22, 2024
@powersj powersj force-pushed the switch/gosyslog branch from 3f0219a to adb8525 Compare May 24, 2024 14:24
@powersj powersj changed the title Switch/gosyslog chore(deps): Switch to github.com/leodido/go-syslog May 24, 2024
@telegraf-tiger telegraf-tiger bot added the chore label May 24, 2024
@powersj powersj marked this pull request as ready for review May 24, 2024 14:41
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 24, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj May 24, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan added the dependencies Pull requests that update a dependency file label May 27, 2024
@srebhan srebhan removed their assignment May 27, 2024
@DStrand1 DStrand1 assigned powersj and unassigned DStrand1 May 29, 2024
Updates a few test cases to no longer error due to the missing EOF. The
non-transparent for strict parsing does need a newline.
@powersj powersj force-pushed the switch/gosyslog branch from adb8525 to 4ed50b9 Compare May 30, 2024 13:33
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 536b3d0 into influxdata:master May 30, 2024
27 checks passed
@powersj powersj deleted the switch/gosyslog branch May 30, 2024 14:06
@github-actions github-actions bot added this to the v1.31.0 milestone May 30, 2024
srebhan added a commit to srebhan/telegraf that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants