Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secretstores.oauth2): Ensure endpoint params is not nil #15531

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix(secretstores.oauth2): Ensure endpoint params is not nil #15531

merged 2 commits into from
Jun 19, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jun 18, 2024

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15530

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jun 18, 2024
@powersj powersj changed the title fix(secretstors.oauth2): Ensure Endpoitn params is not nil fix(secretstors.oauth2): Ensure endpoint params is not nil Jun 18, 2024
@powersj powersj mentioned this pull request Jun 18, 2024
Closed
@powersj powersj marked this pull request as ready for review June 18, 2024 20:28
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 18, 2024
@DStrand1 DStrand1 removed their assignment Jun 18, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch @powersj!

@srebhan srebhan changed the title fix(secretstors.oauth2): Ensure endpoint params is not nil fix(secretstores.oauth2): Ensure endpoint params is not nil Jun 19, 2024
@srebhan srebhan merged commit 80e94f7 into influxdata:master Jun 19, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.31.1 milestone Jun 19, 2024
srebhan pushed a commit that referenced this pull request Jul 1, 2024
@powersj @srebhan
fix(secretstores.oauth2): Ensure endpoint params is not nil (#15531)
d8c8cbb 
(cherry picked from commit 80e94f7)
@BrewTestBot BrewTestBot mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.1
Development

Successfully merging this pull request may close these issues.

OAuth2 Secret store does not work
3 participants
@powersj @srebhan @DStrand1