fix(parsers.xpath): Allow resolving extensions #15586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the XPath parser fails to resolve fields containing extensions due to the fact that extensions are currently not registered globally and thus cannot be resolved by the unmarshaller.
Instead of registering extensions globally this PR uses a parser-specific registry to avoid side effects between different parsers. Unfortunately, extensions are usually distributed across different files that are not imported by the main file. Therefore, all extensions need to be loaded explicitly additionally to the main file. As a consequence the
xpath_protobuf_file
option needs to be replaced byxpath_protobuf_files
(plural) to be able to specify multiple input files.Checklist
Related issues
resolves #15571