Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools.custom_builder): Handle multiple instance of the same plugin correctly #15630

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jul 16, 2024

Summary

The existing code only handles the data-format field correctly for single instances of the same plugin as we overwrite the parsers/serializers for each instance.

This PR fixes the issue and additionally restructures the code to be able to add test-cases and do so for previous issues.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15627

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jul 16, 2024
@srebhan srebhan self-assigned this Jul 16, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 17, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Jul 17, 2024
@powersj powersj removed their assignment Jul 17, 2024
@DStrand1 DStrand1 merged commit a3a8a8c into influxdata:master Jul 17, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.2 milestone Jul 17, 2024
powersj pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in custom_builder scanning of parsers
3 participants