-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common.cookie): Allow usage of secrets for header #15640
Conversation
Thanks so much for the pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I just have one comment about documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Can you please update the documentation in inputs.http and outputs.http as well? Both plugins have a "Secret-store support" config header that list the options that support secret stores. Please add cookie_auth_header
to that list.
I have adapted the documentation locally. @h0nIg Can you please give me access to the repo to push it to the branch? |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -4.44 % for linux amd64 (new size: 251.9 MB, nightly size 263.6 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
common.cookie does not support secretstores, it may be required to send header values based on secretstores
Checklist
Related issues
resolves #15639