Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common.cookie): Allow usage of secrets for header #15640

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

h0nIg
Copy link
Contributor

@h0nIg h0nIg commented Jul 19, 2024

Summary

common.cookie does not support secretstores, it may be required to send header values based on secretstores

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15639

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 19, 2024
@ZPascal
Copy link
Contributor

ZPascal commented Jul 19, 2024

@srebhan or @powersj Could you please take a look?

Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I just have one comment about documentation

plugins/common/cookie/cookie.go Show resolved Hide resolved
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Can you please update the documentation in inputs.http and outputs.http as well? Both plugins have a "Secret-store support" config header that list the options that support secret stores. Please add cookie_auth_header to that list.

@powersj powersj added the waiting for response waiting for response from contributor label Jul 19, 2024
@srebhan srebhan changed the title feat(common.cookie): allow usage of secrets for header feat(common.cookie): Allow usage of secrets for header Jul 19, 2024
@ZPascal
Copy link
Contributor

ZPascal commented Jul 31, 2024

I have adapted the documentation locally. @h0nIg Can you please give me access to the repo to push it to the branch?

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jul 31, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 1, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 1, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -4.44 % for linux amd64 (new size: 251.9 MB, nightly size 263.6 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@DStrand1 DStrand1 removed their assignment Aug 1, 2024
@srebhan srebhan merged commit 9cb121c into influxdata:master Aug 6, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(common.cookie): allow usage of secrets for header
5 participants