Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agent): Enable watching for new configuration files #15645

Merged
merged 2 commits into from
Jul 25, 2024
Merged

feat(agent): Enable watching for new configuration files #15645

merged 2 commits into from
Jul 25, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jul 19, 2024 •
edited
Loading

Summary

This allows for watching for new files in a configuration directory.
When a new file is found, Telegraf will reload with that file added to
the list of files to watch. Note this will reload when any file, a
telegraf config or not, is added to the directory.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #12389
fixes: #12264

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 19, 2024
@powersj powersj self-assigned this Jul 22, 2024
@powersj powersj force-pushed the feat/config-create branch from c6fbdb2 to e5c393a Compare July 23, 2024 14:15
This was referenced Jul 23, 2024
Closed
Closed
powersj added 2 commits July 24, 2024 12:01
@powersj
chore: Update influxdata/tail to master
1f8521a
@powersj
feat(agent): Enable watching for new files
4900613 
This allows for watching for new files in a configuraiton directory.
When a new file is found, Telegraf will reload with that file added to
the list of files to watch. Note this will reload when any file, a
telegraf config or not, is added to the directory.

TODO: test on Windows

fixes: influxdata#12389
fixes: influxdata#12264
@powersj powersj force-pushed the feat/config-create branch from e5c393a to 4900613 Compare July 24, 2024 18:02
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 24, 2024
@powersj powersj marked this pull request as ready for review July 24, 2024 18:03
@powersj powersj assigned DStrand1 and srebhan and unassigned powersj Jul 24, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj! Unfortunately, there is no way to check if the new file actually is a config file so let's continue with this approach.

@srebhan srebhan removed their assignment Jul 25, 2024
@DStrand1 DStrand1 merged commit 777154b into influxdata:master Jul 25, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Jul 25, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
@Hipska Hipska mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
area/agent feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.0
3 participants
@powersj @srebhan @DStrand1