Some improvment in mesos input plugin, #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing uneeded statistics prefix for task's metric,
Adding framework id tags into each task's metric,
Adding state (leader/follower) tags to master's metric,
Make sure the slave's metrics are tags with slave
| @@ -116,7 +116,7 @@ func (m *Mesos) Gather(acc telegraf.Accumulator) error { | |||
| for _, v := range m.Slaves { | |||
| wg.Add(1) | |||
| go func(c string) { | |||
| errorChannel <- m.gatherMainMetrics(c, ":5051", MASTER, acc) | |||
| errorChannel <- m.gatherMainMetrics(c, ":5051", SLAVE, acc) | |||
| tags["state"] = "follower" | ||
| } | ||
| } | ||
|
|
||
| acc.AddFields("mesos", jf.Fields, tags) |
There was a problem hiding this comment.
I've just noticed that slave metrics have timestamp which we can use to pass as fourth parameter to AddFields. It's an extra - you can ignore it if you want. I will try to add this later if you won't.
|
|
||
| acc.AddFields("mesos-tasks", jf.Fields, tags) | ||
| acc.AddFields("mesos-tasks", jf.Fields, tags, timestamp) |
There was a problem hiding this comment.
I should have caught this earlier, but this should be mesos_tasks, not mesos-tasks, could we change that? how long has it been like this for?
There was a problem hiding this comment.
@sparrc this one is from my PR I believe.
|
Alright! I have no more comments! LGTM |
|
@sparrc can we get it merged to master soon? |
|
yes, I should be able to merge this today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unneeded statistics prefix for task's metric,
Adding framework id tags into each task's metric,
Adding state (leader/follower) tags to master's metric,
Make sure the slave's metrics are tags with slave