Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linters): Enable get-return rule for revive #15841

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

zak-pawel
Copy link
Collaborator

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15819

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zak-pawel could you please avoid the formatting changes in config and custom_builder to reduce the changes in this PR to just the linter fixes!?

config/config.go Outdated Show resolved Hide resolved
plugins/aggregators/basicstats/basicstats.go Show resolved Hide resolved
config/config.go Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment...

config/config.go Outdated Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 9, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Sep 9, 2024
@DStrand1 DStrand1 merged commit 9988154 into influxdata:master Sep 12, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Sep 12, 2024
srebhan pushed a commit that referenced this pull request Oct 7, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
4 participants