Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aggregators.basicstats): Add first field #15948

Merged
merged 7 commits into from
Oct 7, 2024
Merged

feat(aggregators.basicstats): Add first field #15948

merged 7 commits into from
Oct 7, 2024

Conversation

tguenneguez
Copy link
Contributor

Summary

Adds a first field to the basic stats aggregator to track the first aggregated value of a metric.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/aggregator 1. Request for new aggregator plugins 2. Issues/PRs that are related to aggregator plugins labels Sep 27, 2024
@tguenneguez tguenneguez marked this pull request as ready for review September 30, 2024 16:56
srebhan
srebhan reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tguenneguez for your contribution! Just one comment to fix the sample.conf. Please remember to run make docs afterwards...

plugins/aggregators/basicstats/sample.conf Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Oct 1, 2024
@tguenneguez @srebhan
Update plugins/aggregators/basicstats/sample.conf
fa48b77 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@srebhan
Copy link
Member

srebhan commented Oct 1, 2024 •
edited
Loading

@tguenneguez you missed out on the make docs part as the Readme also needs updating to make the linter happy!

srebhan
srebhan reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more finding...

plugins/aggregators/basicstats/basicstats.go Outdated Show resolved Hide resolved
srebhan
srebhan approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tguenneguez!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 1, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 1, 2024
@srebhan srebhan added the waiting for response waiting for response from contributor label Oct 7, 2024
@tguenneguez @DStrand1
Update plugins/aggregators/basicstats/README.md
36ce649 
Co-authored-by: Dane Strandboge <136023093+DStrand1@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 7, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan requested a review from DStrand1 October 7, 2024 18:37
@DStrand1 DStrand1 merged commit 31ddd69 into influxdata:master Oct 7, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Oct 7, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@tguenneguez @asaharn
feat(aggregators.basicstats): Add first field (influxdata#15948)
675a732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@DStrand1 DStrand1

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/aggregator 1. Request for new aggregator plugins 2. Issues/PRs that are related to aggregator plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. waiting for response waiting for response from contributor
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tguenneguez @srebhan @DStrand1