Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.diskio): Add field io await and util #15950

Merged
merged 4 commits into from
Oct 3, 2024
Merged

feat(inputs.diskio): Add field io await and util #15950

merged 4 commits into from
Oct 3, 2024

Conversation

jiangxianfu
Copy link
Contributor

Summary

In practical scenarios, it may be necessary to check the values for disk I/O wait, I/O util, and I/O svctm.
Therefore, I would like to add these three metrics.

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@jiangxianfu
Copy link
Contributor Author

jiangxianfu commented Sep 30, 2024 •
edited
Loading

add util/await/svctm #15951

@jiangxianfu
Copy link
Contributor Author

done !signed-cla

jiangxianfu added a commit to jiangxianfu/telegraf that referenced this pull request Sep 30, 2024
@jiangxianfu
fix: markdown bug for influxdata#15951 influxdata#15950
419e433
jiangxianfu added a commit to jiangxianfu/telegraf that referenced this pull request Sep 30, 2024
@jiangxianfu
fix markdown influxdata#15950 influxdata#15951
f80c1f2
jiangxianfu added a commit to jiangxianfu/telegraf that referenced this pull request Sep 30, 2024
@jiangxianfu
feat(inputs.diskio): Add disk io util await svctm(influxdata#15950)
5ebb118
@jiangxianfu jiangxianfu changed the title add disk io util await svctm Add new field util/await/svctm to diskio Sep 30, 2024
@jiangxianfu jiangxianfu changed the title Add new field util/await/svctm to diskio Add new field for diskio Sep 30, 2024
jiangxianfu added a commit to jiangxianfu/telegraf that referenced this pull request Sep 30, 2024
@jiangxianfu
chore(inputs.diskio): Linter comment (influxdata#15950)
bf08149
@jiangxianfu jiangxianfu changed the title Add new field for diskio feat(inputs.diskio) Add field for io await and util Sep 30, 2024
@jiangxianfu jiangxianfu changed the title feat(inputs.diskio) Add field for io await and util feat(inputs.diskio) Add field io await and util Sep 30, 2024
@jiangxianfu jiangxianfu changed the title feat(inputs.diskio) Add field io await and util feat(inputs.diskio): Add field io await and util Sep 30, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 30, 2024
jiangxianfu added a commit to jiangxianfu/telegraf that referenced this pull request Sep 30, 2024
@jiangxianfu
chore(linters): Remove comment (influxdata#15950)
778788a
jiangxianfu added a commit to jiangxianfu/telegraf that referenced this pull request Sep 30, 2024
@jiangxianfu
chore(inputs.disk): Update diskio unit test (influxdata#15950)
6bc4317
jiangxianfu added a commit to jiangxianfu/telegraf that referenced this pull request Sep 30, 2024
@jiangxianfu
chore(input.disk): Update disk io unit test (influxdata#15950)
2a70108
@jiangxianfu jiangxianfu force-pushed the master branch 2 times, most recently from 69f724b to 8a079dc Compare September 30, 2024 13:02
srebhan
srebhan reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiangxianfu for your contribution! I do have some comments in the code.

plugins/inputs/diskio/README.md Outdated Show resolved Hide resolved
plugins/inputs/diskio/diskio.go Outdated Show resolved Hide resolved
plugins/inputs/diskio/diskio.go Outdated Show resolved Hide resolved
plugins/inputs/diskio/diskio.go Outdated Show resolved Hide resolved
plugins/inputs/diskio/diskio_test.go Outdated Show resolved Hide resolved
plugins/inputs/diskio/diskio_test.go Outdated Show resolved Hide resolved
plugins/inputs/diskio/diskio_test.go Outdated Show resolved Hide resolved
plugins/inputs/diskio/diskio_test.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Oct 1, 2024
@jiangxianfu jiangxianfu requested a review from srebhan October 1, 2024 14:57
jiangxianfu added a commit to jiangxianfu/telegraf that referenced this pull request Oct 2, 2024
@jiangxianfu
refactor(inputs.diskio): Merge guage and counter into counter.(influx…
e3b7c62 
…data#15950)
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 2, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question on field naming...

plugins/inputs/diskio/diskio.go Show resolved Hide resolved
srebhan
srebhan approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work and effort @jiangxianfu!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 2, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 2, 2024
@DStrand1 DStrand1 merged commit bcbecb0 into influxdata:master Oct 3, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Oct 3, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@jiangxianfu @asaharn
feat(inputs.diskio): Add field io await and util (influxdata#15950)
7736fe9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jiangxianfu @srebhan @DStrand1