-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(outputs.remotefile): Create a new serializer instance per output file #15968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
pr to fix corresponding bug
plugin/output
1. Request for new output plugins 2. Issues/PRs that are related to out plugins
labels
Oct 2, 2024
srebhan
force-pushed
the
remote_file_issue_15914
branch
from
October 2, 2024 20:34
564cadd
to
14f38be
Compare
DStrand1
approved these changes
Oct 7, 2024
srebhan
added
the
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
label
Oct 11, 2024
@srebhan Could you rebase this PR? |
srebhan
force-pushed
the
remote_file_issue_15914
branch
from
October 14, 2024 18:55
14f38be
to
ffd2f7d
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
DStrand1
approved these changes
Oct 14, 2024
asaharn
pushed a commit
to asaharn/telegraf
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fix
pr to fix corresponding bug
plugin/output
1. Request for new output plugins 2. Issues/PRs that are related to out plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some serializers require a new instance per output stream such as CSV. This PR adds the framework to pass a creator function to plugins if they need it and converts the remotefile output to the new code.
Checklist
Related issues
resolves #15912