Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.remotefile): Create a new serializer instance per output file #15968

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 2, 2024

Summary

Some serializers require a new instance per output stream such as CSV. This PR adds the framework to pass a creator function to plugins if they need it and converts the remotefile output to the new code.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15912

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Oct 2, 2024
@srebhan srebhan self-assigned this Oct 2, 2024
@srebhan srebhan force-pushed the remote_file_issue_15914 branch from 564cadd to 14f38be Compare October 2, 2024 20:34
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 11, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 11, 2024
@DStrand1
Copy link
Member

@srebhan Could you rebase this PR?

@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Oct 14, 2024
@srebhan srebhan force-pushed the remote_file_issue_15914 branch from 14f38be to ffd2f7d Compare October 14, 2024 18:55
@telegraf-tiger
Copy link
Contributor

@DStrand1 DStrand1 merged commit 23fc01c into influxdata:master Oct 14, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.2 milestone Oct 14, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
srebhan added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write CSV Header with Every Remote File
2 participants