Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.win_eventlog): Handle XML data fields' filtering the same way as event fields #16008

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 11, 2024

Summary

Currently, fields extracted from the event's XML cannot be used as tags due to the way the filtering is done. This PR changes the processing to handle those fields the same way as fields extracted from the event itself. Furthermore, the PR transitions the PR to use a filter instead of misusing filepath-matching.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15958

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 11, 2024
@srebhan srebhan added the area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) label Oct 11, 2024
@srebhan srebhan self-assigned this Oct 11, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 17, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 17, 2024
@DStrand1 DStrand1 merged commit aaae84b into influxdata:master Oct 17, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.2 milestone Oct 17, 2024
srebhan added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.win_eventlog does not convert (any/some?) fields to tags
2 participants