-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.opcua): Allow to retry reads on invalid sessions #16026
Conversation
ffbade9
to
e26c0b5
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'll pass it back to you since you had another question for the issue author
Checked again and I'm sure the PR works as the reporter stated... |
(cherry picked from commit 0abd184)
Summary
In cases where a session becomes invalid (e.g. due to the server not respecting the session timeout) we should retry the read after some time to allow the client to reactivate the session. This is done using the newly introduced
read_retry_timeout
andread_retry_count
settings.Checklist
Related issues
resolves #15998