Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.snmp): Fix crash when trying to format fields from unknown OIDs #16155

Merged

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Nov 6, 2024

Summary

Check if the returned Node actually has a Type object.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16153

@telegraf-tiger telegraf-tiger bot added area/snmp fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 6, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 6, 2024

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 6, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska!

@srebhan srebhan merged commit 58b4126 into influxdata:master Nov 7, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Nov 7, 2024
@Hipska Hipska deleted the fix/inputs/snmp_translate_crash branch November 18, 2024 16:17
srebhan pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNMP Plugin - Telegraf crash when mib file is missing
3 participants