Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common.socket): Use read buffer size config setting as a datagram reader buffer size. #16156

Merged
merged 14 commits into from
Nov 18, 2024

Conversation

MarekZydor
Copy link
Contributor

@MarekZydor MarekZydor commented Nov 6, 2024

Summary

Currently, the datagram read buffer size is fixed at 64 KB, which is leading
to data loss when receiving large datagrams (metrics) over Unix Domain Sockets (unixgram).
This fix ensures that the buffer size matches read-buffer-size
configuration, preventing truncation of incoming data.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16118

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Nov 6, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarekZydor thanks for your contribution! Please fix the unit-test so we can get this merged.

plugins/inputs/socket_listener/socket_listener_test.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Nov 7, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarekZydor for the update. Two small comments then we are good to go I think...

@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Nov 14, 2024
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.31 % for linux amd64 (new size: 262.4 MB, nightly size 256.5 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarekZydor!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 18, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Nov 18, 2024
@DStrand1 DStrand1 merged commit e28c33e into influxdata:master Nov 18, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Nov 18, 2024
srebhan pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.socket_listener] Metric size limit received via udp/unixgram
3 participants