-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.netflow): Decode flags in TCP and IP headers correctly #16248
Conversation
…aders Golang switch block does not do automatic fallthrough so it must be explicitly added to handle multiple cases
…itch statements to if statements fallthrough usage is not valid because next condition is not evaluated
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for spotting this @joseluisgonzalezca! The contribution is much appreciated!
Could you please also check the other decoders!?!
Hi Sven, I've reviewed the sFlow decoder source code and I haven't detected any additional issues. Nevertheless, we are actively using the plugin and checking received metrics. As soon as I found any anomaly, I will report it and try to solve it. Thanks! |
…fluxdata#16248) Co-authored-by: jlgonzalez <jlgonzalez@sarenet.es>
Summary
This problem is present during IPv4 header decoding and TCP header decoding. Both issues have been fixed in this PR.
Golang switch block does not do automatic fallthrough so it must be explicitly added to handle multiple cases
Checklist
Related issues
resolves issue #16247