Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignalFx output plugin #1698

Closed
wants to merge 2 commits into from
Closed

Add SignalFx output plugin #1698

wants to merge 2 commits into from

Conversation

ewbankkit
Copy link

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

For those whose love Telegraf for metrics collection but prefer to use SignalFx for storage and analysis.
May need to revisit SignalFx datapoint type once/if #1694 is merged.

@ewbankkit
Copy link
Author

OK, need to add back opencontainers to Godeps...

@jwilder jwilder added the feature request Requests for new plugin and for new features to existing plugins label Sep 1, 2016
@nhaugo nhaugo self-assigned this Sep 1, 2016
@ewbankkit
Copy link
Author

  • Rebased with latest master
  • Added support for Telegraf metric types
  • Added name sanitization, similar to Prometheus output plugin

Kit Ewbank added 2 commits September 21, 2016 11:34
Add back 'opencontainers' to 'Godeps' to fix CircleCI error.
@ewbankkit
Copy link
Author

I'll follow and integrate with the outcome of #1717 and #1718.

@nhaugo
Copy link
Contributor

nhaugo commented Oct 13, 2016

@ewbankkit Sorry about the delay on the merge, but it looks like you figured out the reason. We should be able to get this merged once we have the plugins checked in.

@nhaugo nhaugo removed their assignment Oct 13, 2016
@ewbankkit
Copy link
Author

Is an exec output plugin in the works: #544?

@sparrc
Copy link
Contributor

sparrc commented Oct 17, 2016

@ewbankkit not at the moment, but we may want to prioritize that for a 1.x release to better enable external plugins.

@ewbankkit
Copy link
Author

Addresses #923.

@ewbankkit
Copy link
Author

Closing this PR as an exec output plugin seems to be the longer-term way forward.
See #1999.

@ewbankkit ewbankkit closed this Nov 4, 2016
@amoghe
Copy link
Contributor

amoghe commented Feb 26, 2018

@ewbankkit any chance we could revive this and have a built-in signalfx output plugin (seeing as how the exec one never fully landed)?

If you could point out the remaining work you'd like to see as part of this PR, I'd be happy to take over and see it through to completion.

@ewbankkit
Copy link
Author

@amoghe Please feel free to take this over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants