Rewriting Riemann output plugin #1900

JamesClonk · 2016-10-15T15:42:21Z

Required for all PRs:

CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
Sign CLA (if not already signed)
README.md updated (if adding a new plugin)

Todo:

Unit tests
Integration tests
README.md

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

rclayton-the-terrible · 2017-01-13T17:47:13Z

Any ideas if this will be merged?

sparrc · 2017-01-13T17:51:30Z

I will be trying to get it reviewed next week and hopefully will have it merged within a few weeks, then it will first be in an official release for 1.3

sparrc

Overall looks very good, just want some clarification on a few points and some small tweaks.

sparrc · 2017-01-24T22:18:19Z

etc/telegraf.conf

+#   address = "localhost:5555"
+#
+#   ## Transport protocol to use, either tcp or udp
+#   transport = "tcp"


can you just make the scheme part of the address string?

ie:

address = "tcp://localhost:5555"

I could, but then I'd have to split/parse it to take it apart again anyway, since the Riemann library needs the protocol and address as separate parameters. address is not used anywhere else otherwise. It's not a complicated thing to do, but I don't see the benefit of it?

two benefits:

we can use url.Parse to validate the provided URL

it's more consistent with the configuration of other plugins

sparrc · 2017-01-24T22:18:44Z

etc/telegraf.conf

+#
+#   ## Riemann TTL, floating-point time in seconds.
+#   ## Defines how long that an event is considered valid for in Riemann
+#   # ttl = 30.0


what is a "Riemann TTL"? Can you link to documentation?

I meant a Riemann event TTL. It's described here: http://riemann.io/concepts.html
I clarified the description text a bit.

sparrc · 2017-01-24T22:21:27Z

etc/telegraf.conf

+#
+#   ## Set measurement name as a Riemann attribute,
+#   ## instead of prepending it to the Riemann service name
+#   # measurement_as_attribute = false


Can you provide more details on what this means? can you provide an example? How does using this option affect the separator option?

I tried to clarify the description text a bit. I also added an example Riemann event with this setting to the plugins Readme.md.

sparrc · 2017-01-24T22:22:33Z

plugins/outputs/riemann_legacy/riemann.go

+	"github.com/influxdata/telegraf/plugins/outputs"
+)
+
+const deprecationMsg = "I! WARNING: this Riemann output plugin will be deprecated in a future release, see https://github.com/influxdata/telegraf/issues/1878 for more details & discussion."


make this an error message, starting with E!

sparrc · 2017-01-24T22:26:02Z

etc/telegraf.conf

+#
+#   ## A list of tag keys whose values get sent as Riemann tags.
+#   ## If empty, all Telegraf tag values will be sent as tags
+#   # tag_keys = ["telegraf","custom_tag"]


weren't we going to send tags as riemann "attributes" instead of as tags? is that what you mean by "Riemann tags"?

Yes, Telegraf/Influx/Metrics2.0 tags will be sent as Riemann attributes, which are key/value pairs. But Riemann also has a notion of "Riemann tags" which are just single string thingies. (Kinda like in Graphite I guess?)
This option allows setting such additional tags.

OK, fair enough

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

jagregory · 2017-01-27T09:37:19Z

Pretty keen on this. If you need anything testing I'll be using this immediately :)

sparrc · 2017-01-27T18:31:15Z

just wanted to consolidate the transport and address config options into a single option.

@JamesClonk do you have any objections to making that change?

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

JamesClonk · 2017-01-27T19:34:43Z

@sparrc ok, I changed it into the combined url setting.

* rename to riemann_legacy Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * initial draft for Riemann output plugin rewrite Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add unit tests Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add option to send string metrics as states Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add integration tests Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add plugin README.md Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * bump riemann library * clarify settings description Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * update Readme.md with updated description Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add Riemann event examples Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * use full URL for Riemann server address Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> closes influxdata#1878

* rename to riemann_legacy Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * initial draft for Riemann output plugin rewrite Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add unit tests Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add option to send string metrics as states Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add integration tests Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add plugin README.md Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * bump riemann library * clarify settings description Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * update Readme.md with updated description Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * add Riemann event examples Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> * use full URL for Riemann server address Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com> closes #1878

JamesClonk added 2 commits October 15, 2016 17:35

rename to riemann_legacy

6023fb3

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

initial draft for Riemann output plugin rewrite

417560a

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

JamesClonk mentioned this pull request Oct 15, 2016

Rewrite Riemann output plugin #1878

Closed

JamesClonk added 4 commits October 15, 2016 18:24

add unit tests

1726103

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

add option to send string metrics as states

c038bf3

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

add integration tests

54fa55d

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

add plugin README.md

2021ebc

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

sparrc added this to the 1.2.0 milestone Nov 2, 2016

bump riemann library

d77d2e8

sparrc added plugin request and removed plugin request labels Nov 26, 2016

sparrc modified the milestones: 1.2.0, 1.3.0 Jan 10, 2017

sparrc suggested changes Jan 24, 2017

View reviewed changes

JamesClonk added 3 commits January 25, 2017 12:38

clarify settings description

8586bab

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

update Readme.md with updated description

d8e8260

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

add Riemann event examples

3a7f638

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

use full URL for Riemann server address

281e1ff

Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>

sparrc approved these changes Jan 27, 2017

View reviewed changes

sparrc added 2 commits January 27, 2017 14:51

Merge branch 'master' into master

6f6ed1c

Merge branch 'master' into master

e4b78cb

sparrc merged commit 3fa37a9 into influxdata:master Jan 27, 2017

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewriting Riemann output plugin #1900

Rewriting Riemann output plugin #1900

JamesClonk commented Oct 15, 2016 •

edited

Loading

rclayton-the-terrible commented Jan 13, 2017

sparrc commented Jan 13, 2017

sparrc left a comment •

edited

Loading

sparrc Jan 24, 2017

JamesClonk Jan 25, 2017

sparrc Jan 25, 2017

sparrc Jan 24, 2017

JamesClonk Jan 25, 2017

sparrc Jan 24, 2017

JamesClonk Jan 25, 2017 •

edited

Loading

sparrc Jan 24, 2017

JamesClonk Jan 25, 2017

sparrc Jan 24, 2017

JamesClonk Jan 25, 2017

sparrc Jan 25, 2017

jagregory commented Jan 27, 2017

sparrc commented Jan 27, 2017

JamesClonk commented Jan 27, 2017

Rewriting Riemann output plugin #1900

Rewriting Riemann output plugin #1900

Conversation

JamesClonk commented Oct 15, 2016 • edited Loading

Required for all PRs:

Todo:

rclayton-the-terrible commented Jan 13, 2017

sparrc commented Jan 13, 2017

sparrc left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JamesClonk Jan 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jagregory commented Jan 27, 2017

sparrc commented Jan 27, 2017

JamesClonk commented Jan 27, 2017

JamesClonk commented Oct 15, 2016 •

edited

Loading

sparrc left a comment •

edited

Loading

JamesClonk Jan 25, 2017 •

edited

Loading