Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart: Gather S.M.A.R.T. information from storage devices #2402

Closed
wants to merge 1 commit into from

Conversation

rickard-von-essen
Copy link
Contributor

@rickard-von-essen rickard-von-essen commented Feb 13, 2017

This adds a new input plugin which uses the smartctl utility from the
smartmontools package to gather metrics from S.M.A.R.T. storage devices.

Signed-off-by: Rickard von Essen rickard.von.essen@gmail.com

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

@rickard-von-essen
Copy link
Contributor Author

I'll do some verification of this and come back when I think it's tested.

This adds a new input plugin which uses the `smartctl` utility from the
smartmontools package to gather metrics from S.M.A.R.T. storage devices.

Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
@sparrc
Copy link
Contributor

sparrc commented Feb 13, 2017

@rickard-von-essen there is already a PR for this feature: #2319

feel free to re-open if your PR adds any additional functionality and you think we should use yours instead.

@sparrc sparrc closed this Feb 13, 2017
@sebito91 sebito91 mentioned this pull request Feb 13, 2017
3 tasks
@rickard-von-essen
Copy link
Contributor Author

Damn, #2319 must have been opened just after I started. I'll review and test that and comment there.

@rickard-von-essen
Copy link
Contributor Author

@sparrc I think we should reopen this and compare the basic structure of the code with #2319.

@rickard-von-essen
Copy link
Contributor Author

rickard-von-essen commented Feb 17, 2017

TODO:

  • Properly handle exit codes
  • Run gathering of metrics concurrently
  • Split metrics into smart_device and smart_attribute.
  • Handle versions 5.41, 5.42, 5.43, 6.[0-6]
  • Update README.md, versions limitations (5.41, 5.42 + nocheck), new format, sudo

@rickard-von-essen rickard-von-essen changed the title WIP: smart: Gather S.M.A.R.T. information from storage devices smart: Gather S.M.A.R.T. information from storage devices Feb 20, 2017
@rickard-von-essen
Copy link
Contributor Author

rickard-von-essen commented Feb 20, 2017

EDIT: opened a new PR, see #2449

@sparrc I think we should reopen this (only collaborators/owners can do that).

I have updated this with more documentation, concurrent metrics gathering, different metrics structure, verified against version 5.41, 5.42, 5.43, 6.0, 6.1, 6.2, 6.3, 6.4, and 6.5.

@sebito91 It would be awesome if you would help testing this by testing the performance on your 96-disk system and verify that this would also cover your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants