Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample for exec plugin. Fixes #245 #258

Closed
wants to merge 1 commit into from

Conversation

ekini
Copy link
Contributor

@ekini ekini commented Oct 13, 2015

No description provided.


The collected metrics will be:
```
exec_catter_a value=0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain where catter comes from as well, I'm assuming this is from name?

Also, while you're here, can you remove the interval section of the README, this is redundant since it's the same for every plugin

@sparrc
Copy link
Contributor

sparrc commented Oct 13, 2015

Thanks @ekini! Just a couple comments 👍

@ekini
Copy link
Contributor Author

ekini commented Oct 13, 2015

  1. Replaced "catter" to "mycollector" to make the doc consistent.
  2. The plugin doesn't ignore ints, but it treats them as floats. I'm not sure what happens when it passes them to accumulator, and values there are interface{}.
  3. As far as I see from the codeI, the interval parameter here is different from the common one.
    For example, if exec.interval = 20, and agent.interval = 10, then the command will be run only once.

@sparrc
Copy link
Contributor

sparrc commented Oct 13, 2015

re 3: that's true, I forgot about that, someone added that so you can configure interval on a per-collector basis

re 1 & 2: looks good, thank you!

@sparrc sparrc closed this in 2a9f31b Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants