-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding option to randomize Kinesis partition key #2705
adding option to randomize Kinesis partition key #2705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update the README for this plugin.
plugins/outputs/kinesis/kinesis.go
Outdated
## If set the paritionKey will be a random UUID on every put. | ||
## This allows for scaling across multiple shards in a stream. | ||
## This will cause issues with ordering. | ||
randomize_partitionKey = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to use_random_partitionkey
. Mention that if this is set then partitionkey
is ignored. Can you explain a little about the ordering issues (perhaps in the README)
Godeps
Outdated
@@ -19,6 +19,7 @@ github.com/go-sql-driver/mysql 2e00b5cd70399450106cec6431c2e2ce3cae5034 | |||
github.com/gobwas/glob bea32b9cd2d6f55753d94a28e959b13f0244797a | |||
github.com/golang/protobuf 8ee79997227bf9b34611aee7946ae64735e6fd93 | |||
github.com/golang/snappy 7db9049039a047d955fe8c19b83c8ff5abd765c7 | |||
github.com/google/uuid 6a5e28554805e78ea6141142aba763936c4761c0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to use https://github.com/satori/go.uuid for uuids.
Great, just update the CHANGELOG. |
Required for all PRs: