Add JSON input to zipkin plugin #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, fmt.Errorf("No value for key %s at binaryAnnotations[%d]", a.K, i) | ||
| } | ||
| if a.Value() != "" && a.Key() == "" { | ||
| return nil, fmt.Errorf("No at binaryAnnotations[%d]", i) |
There was a problem hiding this comment.
Not sure what this error means, also is binaryAnnotations going to be clear to user?
plugins/inputs/zipkin/handler.go
Outdated
| // ContentType returns a Decoder that is able to produce Traces from bytes. | ||
| // Failure should yield an HTTP 415 (`http.StatusUnsupportedMediaType`) | ||
| // If a Content-Type is not set, zipkin assumes application/json | ||
| func ContentType(r *http.Request) (codec.Decoder, error) { |
There was a problem hiding this comment.
I would consider renaming this function, the current name does not indicate what the function does.
danielnelson
pushed a commit
that referenced
this pull request
Aug 22, 2017
(cherry picked from commit 13a6b91)
1 task
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3137
Required for all PRs:
This PR updates the zipkin plugin to accept JSON V1 zipkin span format: https://github.com/openzipkin/zipkin-api/blob/master/zipkin-api.yaml
Refactored the decoding and encoding of spans into
Traceby creating acodecpackage.Test coverage significantly increased.
This structure should allow supporting zipkin JSON v2 span format: openzipkin/zipkin#1499