Add timeout option for kubernets #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch provided by jchauncey
|
This code is provided by @jchauncey in #3203 |
danielnelson
reviewed
Sep 8, 2017
| if k.ResponseTimeout.Duration < time.Second { | ||
| k.ResponseTimeout.Duration = time.Second * 5 | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
This err check should go away, there is nothing to check here.
| k.RoundTripper = &http.Transport{ | ||
| TLSHandshakeTimeout: 5 * time.Second, | ||
| TLSClientConfig: tlsCfg, | ||
| ResponseHeaderTimeout: time.Duration(3 * time.Second), | ||
| ResponseHeaderTimeout: k.ResponseTimeout.Duration, |
There was a problem hiding this comment.
Just thinking aloud, we should switch to a http.client sometime so we can include the time to get the body. We are no worse off now with this change so not required.
|
@adrianlzt I can fix the above issues if that's easier. |
danielnelson
added
the
feat
|
sure @danielnelson |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch provided by jchauncey
Required for all PRs: