-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add librato output plugin, update datadog plugin #322
Conversation
322c1c1
to
2fa0333
Compare
2fa0333
to
8df0c63
Compare
looks great, thanks much @jipperinbham 👍 |
) | ||
|
||
type Librato struct { | ||
ApiUser string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go style tends to capitalize 3-letter acronyms. So this should be APIUser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know, I assume I'd need to annotate it with toml:"api_user"
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apiUser
would be more inline with what we would do in core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, my understanding was fields needed to be exported in order to be set properly from the toml config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm talking about the JSON encoding tag names. They can be lower case.
So be clear, the core team would write:
type Librato struct {
APIUser string `json:"apiUser"`
}
Some style suggestions, which would be more inline with how we code in Core. Not a big deal however. |
The following PR serves 2 purposes:
float64
Also added READMEs for each output.