Respect path prefix in influx output uri #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add a unittest? |
|
@danielnelson I wasn't sure what kind of new unittest to add in order to properly test the path prefix support, so I chose running the |
|
I would write a new testcase that only tests the path handling, it can do both the write and query operations. The handler just needs to test that the path is correct and that's it. |
Basically reverts fb851ad. Since path prefixes for http urls are now supported, this clarification isn't needed.
dimrozakis
force-pushed
the
influxdb-output-path-prefix
branch
from
d0682d7
to
c0047e2
Compare
dimrozakis
force-pushed
the
influxdb-output-path-prefix
branch
from
c0047e2
to
d4d3c2d
Compare
|
@danielnelson I changed the tests as requested |
danielnelson
added
area/influxdb
feat
danielnelson
pushed a commit
that referenced
this pull request
Oct 18, 2017
(cherry picked from commit 9c8f4af)
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues:
Duplicate of PR #2751, attempts to address #2751 (comment)
Required for all PRs: