Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert datid to a string for backwards compatibility #3638

Closed
wants to merge 2 commits into from

Conversation

danielnelson
Copy link
Contributor

closes #3622

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added area/postgresql fix pr to fix corresponding bug labels Jan 4, 2018
@danielnelson danielnelson added this to the 1.5.1 milestone Jan 4, 2018
@danielnelson
Copy link
Contributor Author

@james-lawrence I could use some advice here if you can spare the time. Please ignore the code here so far, it won't work.

I introduced a regression into 1.5 causing oid types to be converted to ints instead of strings, so I'm trying to undo that. Since this also affects postgresql_extensible I would like it to apply to all oids.

It seems like to fix this I will need to pass the row.ColumnTypes() into accRow() and then use that to setup the columnMap and columnVars with the correct types. Do you think this is the best way to go about a fix?

@james-lawrence
Copy link
Contributor

@danielnelson do you know what commit caused the regression so I can take a look?

@danielnelson
Copy link
Contributor Author

It was part of #3210, when we updated pgx. I believe it was added in jackc/pgx@bec9bd2, quite some time back.

@james-lawrence
Copy link
Contributor

james-lawrence commented Jan 5, 2018

ah, so basically the driver added first class support for the type which changed the default output.

unfortunately atm there isn't a good way of doing this. once jackc/pgx#365 is merged we should be able to configure the output for types.

@danielnelson
Copy link
Contributor Author

Too bad, I guess I'll just whip a release note for this item then. Thanks for the help

@danielnelson danielnelson deleted the postgresql-datid-type branch January 5, 2018 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/postgresql fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL input error after upgrade to 1.5.0 - datid is integer instead of string
2 participants