-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rabbitmq_queue gathering be configurable #3702
Conversation
I'm somewhat adverse to adding new boolean options, as they don't scale up very well and become confusing especially if they become dependent on other options. What I'd like to do is something similar to our other filter options and have an include and exclude list that supports globs:
There is a good example of this in the docker input with |
@danielnelson |
@ildarsv Why not just check if |
Alright, I like this way too, let me do it |
@danielnelson I will appreciate if you make some comment/review for this PR when you have time. |
Since influxdata/telegraf#3702 was merged we can skip `rabbitmq_queue` measurement. We don't have alerts/dashboards based on this metrics. Let's disable gathering. PROD-Related: PROD-17026 Change-Id: I8da572741918506a139f02d92f04aec08934068d
Required for all PRs:
PR for the #3701