Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rabbitmq_queue gathering be configurable #3702

Merged
merged 6 commits into from
Jan 29, 2018

Conversation

ildarsv
Copy link
Contributor

@ildarsv ildarsv commented Jan 19, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

PR for the #3701

@danielnelson
Copy link
Contributor

I'm somewhat adverse to adding new boolean options, as they don't scale up very well and become confusing especially if they become dependent on other options. What I'd like to do is something similar to our other filter options and have an include and exclude list that supports globs:

queues_exclude = ["*"]

There is a good example of this in the docker input with container_name_include and container_name_exclude.

@ildarsv
Copy link
Contributor Author

ildarsv commented Jan 20, 2018

@danielnelson
Yes, It is not the best solution, but in case you have 1000+ queues (some of them can be temporary) and you don't want to gather rabbitmq_queue at all, you can apply queues_exclude = ["*"]. But the telegraf will make request to the RabbitMQ API to grab all these queues stats anyway. ~1Mb will be requested in every collecting interval, it causes timeouts from time to time and overloads network. Not only I have faced this issue, @kerams seems to have faced this issue as well (see #3701).

@kerams
Copy link
Contributor

kerams commented Jan 20, 2018

@ildarsv Why not just check if queues_exclude contains *, in which case you don't query the API at all?

@ildarsv
Copy link
Contributor Author

ildarsv commented Jan 23, 2018

Alright, I like this way too, let me do it

@ildarsv
Copy link
Contributor Author

ildarsv commented Jan 29, 2018

@danielnelson I will appreciate if you make some comment/review for this PR when you have time.

@danielnelson danielnelson added this to the 1.6.0 milestone Jan 29, 2018
@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/rabbitmq labels Jan 29, 2018
@danielnelson danielnelson merged commit da12c64 into influxdata:master Jan 29, 2018
@ildarsv ildarsv deleted the skip-rabbitmq_queue branch January 30, 2018 15:46
cloudlab-autobuild pushed a commit to salt-formulas/salt-formula-rabbitmq that referenced this pull request Feb 2, 2018
Since influxdata/telegraf#3702 was merged
we can skip `rabbitmq_queue` measurement. We don't have
alerts/dashboards based on this metrics. Let's disable gathering.

PROD-Related: PROD-17026 

Change-Id: I8da572741918506a139f02d92f04aec08934068d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants