FP 3959 add option to unbound module to use threads as tags #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
the
feat
|
@aromeyer Do you have time to review this code? |
plugins/inputs/unbound/unbound.go
Outdated
| // is this a thread related value? | ||
| if s.ThreadAsTag && strings.HasPrefix(stat, "thread") { | ||
| // split the that | ||
| statTokens := strings.Split(stat, ".") |
There was a problem hiding this comment.
Check that it split correctly before indexing.
There was a problem hiding this comment.
Done! - I think :)
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3959
Required for all PRs: