Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring an AWS endpoint_url #4485

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Add support for configuring an AWS endpoint_url #4485

merged 1 commit into from
Jul 31, 2018

Conversation

danielnelson
Copy link
Contributor

closes #4479

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 28, 2018
@danielnelson danielnelson added this to the 1.8.0 milestone Jul 28, 2018
@danielnelson danielnelson added the area/aws AWS plugins including cloudwatch, ecs, kinesis label Jul 28, 2018
@danielnelson
Copy link
Contributor Author

@jcmcken Do you think you could verify this change for me, here is an amd64 rpm, but let me know if you need a different build.

@jcmcken
Copy link
Contributor

jcmcken commented Jul 30, 2018

@danielnelson I'll give it a try

@jcmcken
Copy link
Contributor

jcmcken commented Jul 31, 2018

👍 This works

@danielnelson danielnelson requested a review from glinton July 31, 2018 21:32
@glinton glinton merged commit 93ed28e into master Jul 31, 2018
@glinton glinton deleted the aws-endpoint-config branch July 31, 2018 22:07
rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
@danielnelson @rgitzel
Add support for configuring an AWS endpoint_url (influxdata#4485)
0bf62b1
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@danielnelson @otherpirate
Add support for configuring an AWS endpoint_url (influxdata#4485)
fcdb059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

AWS-related plugins should support arbitrary endpoint URLs
3 participants
@danielnelson @jcmcken @glinton